From: Jie Liu <jeff.liu@xxxxxxxxxx> We currently return EINVAL when trying to set more ACL entries than XFS_ACL_MAX_ENTRIES(), but it would be a bit more meaningful to return ENOSPC in this situation, because the later is used to indicate there is no more space to store new ACLs IMHO. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> --- fs/xfs/xfs_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c index 370eb3e..4e54a4d 100644 --- a/fs/xfs/xfs_acl.c +++ b/fs/xfs/xfs_acl.c @@ -397,7 +397,7 @@ xfs_xattr_acl_set(struct dentry *dentry, const char *name, if (error) goto out_release; - error = -EINVAL; + error = -ENOSPC; if (acl->a_count > XFS_ACL_MAX_ENTRIES(XFS_M(inode->i_sb))) goto out_release; -- 1.8.3.2 _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
