On Wed, Nov 06, 2013 at 12:07:16PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The libxfs dquot buffer code uses do_div() with a 32 bit numerator. > This gives incorrect results as do_div() passes the numerator by > reference as a pointer to a 64 bit value. Hence it does the division > using 32 bits of garbage gives the wrong result. > > As per Christoph's suggestion, we can kill the usage of do_div() > here completely and just do the division directly, both in userspace > and kernel space. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs