On Tue, Oct 15, 2013 at 09:17:50AM +1100, Dave Chinner wrote: > All of the buffer operations structures are needed to be exported > for xfs_db, so move them all to a common location rather than > spreading them all over the place. They are verifying the on-disk > format, so while xfs_format.h might be a good place, it is not part > of the on disk format. > > Hence we need to create a new header file that we centralise these > related definitions. Start by moving the bffer operations > structures, and then also move all the other definitions that have > crept into xfs_log_format.h and xfs_format.h as there was no other > shared header file to put them in. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> /root/xfs/fs/xfs/xfs_file.c /root/xfs/fs/xfs/xfs_file.c: In function ‘xfs_file_fallocate’: /root/xfs/fs/xfs/xfs_file.c:844: error: ‘XFS_TRANS_WRITEID’ undeclared (first use in this function) /root/xfs/fs/xfs/xfs_file.c:844: error: (Each undeclared identifier is reported only once /root/xfs/fs/xfs/xfs_file.c:844: error: for each function it appears in.) /root/xfs/fs/xfs/xfs_file.c:860: error: ‘XFS_ICHGTIME_MOD’ undeclared (first use in this function) /root/xfs/fs/xfs/xfs_file.c:860: error: ‘XFS_ICHGTIME_CHG’ undeclared (first use in this function) /root/xfs/fs/xfs/xfs_file.c:864: error: ‘XFS_TRANS_SYNC’ undeclared (first use in this function) make[1]: *** [/root/xfs/fs/xfs/xfs_file.o] Error 1 Gah. Maybe due to pulling in Christoph's series. I'll look into it more tomorrow. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs