On Tue, Oct 22, 2013 at 11:36:15AM +0400, Denis Efremov wrote: > Reorder of assert and args pointer dereference. > > Found by Linux Driver Verification project (linuxtesting.org) - > PVS-Studio analyzer. > > Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx> > --- > fs/xfs/xfs_dir2_node.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c > index 4c3dba7..0ba7382 100644 > --- a/fs/xfs/xfs_dir2_node.c > +++ b/fs/xfs/xfs_dir2_node.c > @@ -1365,8 +1365,8 @@ xfs_dir2_leafn_split( > * Allocate space for a new leaf node. > */ > args = state->args; > - mp = args->dp->i_mount; > ASSERT(args != NULL); > + mp = args->dp->i_mount; Just remove the ASSERT. Either way we are going to panic. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
