On Mon, Oct 21, 2013 at 06:11:29PM -0500, Ben Myers wrote: > On Tue, Oct 15, 2013 at 09:17:51AM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > The on-disk format definitions for the directory and attribute > > structures are spread across 3 header files right now, only one of > > which is dedicated to defining on-disk structures and their > > manipulation (xfs_dir2_format.h). Pull all the format definitions > > into a single header file - xfs_da_format.h - and switch all the > > code over to point at that. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > IIRC Christoph had some concerns with this one, but it wasn't very clear > exactly what they were. This looks ok to me. Christoph did you have anything > more to add? I pulled some of the btree specific definitions back into xfs_btree.h (key, ptr unions), but I left the bmbt_rec-host definitions in the header as I haven't worked out exactly how to relocate them without introducing new dependencies everywhere. Hence I've cleaned up most of what Christoph asked for, but I'm leaving the hard part for a separate patch(set) where it will be (hopefully) much clearer what is being moved and what dependencies it reintroduces. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
