Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gents,

On Mon, Oct 14, 2013 at 03:51:52PM +1100, Dave Chinner wrote:
> On Sat, Oct 12, 2013 at 12:55:05AM -0700, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Still unused after all this time, so removing it is fine by me.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

An xfs ioctl user who requests nonblocking behavior will no longer get it.
This seems to constitute API breakage.  How can we verify that this is unused
since anyone can open with O_NONBLOCK?

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux