On Sat, Oct 12, 2013 at 12:55:08AM -0700, Christoph Hellwig wrote: > Now that only one caller of xfs_change_file_space is left it can be merged > into said caller. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> One question, though: > + case XFS_IOC_ALLOCSP: > + case XFS_IOC_ALLOCSP64: > + case XFS_IOC_FREESP: > + case XFS_IOC_FREESP64: Should we, at this point, mark these ioctls as deprecated and schedule then for removal given that we've recommended against using them for the past 10 years and we have fallocate() now? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs