Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/29/13 10:15 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> They were missed in the original patch that was committed.

I'm not sure it's required in lookup or remove, at least today
nothing looks at it on those paths, does it?

Anyway, matches kernel, at worst the last 2 are harmless:

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>


> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  libxfs/xfs_dir2.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libxfs/xfs_dir2.c b/libxfs/xfs_dir2.c
> index 010c701..96a3c1d 100644
> --- a/libxfs/xfs_dir2.c
> +++ b/libxfs/xfs_dir2.c
> @@ -194,6 +194,7 @@ xfs_dir_createname(
>  	memset(&args, 0, sizeof(xfs_da_args_t));
>  	args.name = name->name;
>  	args.namelen = name->len;
> +	args.filetype = name->type;
>  	args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>  	args.inumber = inum;
>  	args.dp = dp;
> @@ -268,6 +269,7 @@ xfs_dir_lookup(
>  	memset(&args, 0, sizeof(xfs_da_args_t));
>  	args.name = name->name;
>  	args.namelen = name->len;
> +	args.filetype = name->type;
>  	args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>  	args.dp = dp;
>  	args.whichfork = XFS_DATA_FORK;
> @@ -323,6 +325,7 @@ xfs_dir_removename(
>  	memset(&args, 0, sizeof(xfs_da_args_t));
>  	args.name = name->name;
>  	args.namelen = name->len;
> +	args.filetype = name->type;
>  	args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>  	args.inumber = ino;
>  	args.dp = dp;
> 

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux