Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore

[Rich Johnston <rjohnston@xxxxxxx>]

On 10/07/2013 08:08 PM, Dave Chinner wrote:
> On Mon, Oct 07, 2013 at 02:38:35PM -0500, rjohnston@xxxxxxx wrote:
> > +# create files for test 1, a large file so the sparse file
> > +# is in the next stream.
> > +_create_test1_files()
> > +{
> > +
> > +	dd if=/dev/zero of=$SCRATCH_MNT/$DUMPDIR/10MB bs=1MB \
> > +		count=10 2>&1 >> $seqres.full | _filter_dd
> > +	truncate --size=1t $SCRATCH_MNT/$DUMPDIR/sparse0 2>&1 \
> > +		>> $seqres.full
>
> I just noticed that 'truncate' is used here - we don't use that
> anywhere else in xfstests, so either you need test for it in
> common/config and use $TRUNCATE_PROG, or do like every other test
> does and use:
>
> 	$XFS_IO_PROG -c "truncate 1t" $SCRATCH_MNT/$DUMPDIR/sparse0
Good point I will make the changes.
> Cheers,
>
> Dave.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs