Test 259 tries to make a loop device size which is 1 byte less than 4T; losetup now warns that this makes little sense, and the warning breaks the test output: +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored. The RH QE testcase did originally use loopback, so did not in effect test anything other than 512-multiple boundaries. Just drop the non-512-byte-multiple cases, they produce devices exactly the same size as their 512-byte-multiple neighbors. (FWIW, this is a regression test for the bug that d943b11 mkfs: get size of device properly fixed.) Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- V2, sorry, sent wrong version that still had a 1025 "del" value. diff --git a/tests/xfs/259 b/tests/xfs/259 index 59eeaca..9c12ccf 100755 --- a/tests/xfs/259 +++ b/tests/xfs/259 @@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image # Test various sizes slightly less than 4 TB four_TB=$(_math "2^42") -for del in 1 512 1024 2048 4096; do +for del in 512 1024 1025 2048 4096; do ddseek=$(_math "$four_TB - $del") echo "Trying to make (4 TB - $del) B long xfs fs image" rm -f "$testfile" _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs