On 09/27/13 11:55, Eric Sandeen wrote:
On 9/27/13 9:00 AM, tinguely@xxxxxxx wrote:
Free the memory in error path of xlog_recover_add_to_trans().
Normally this memory is freed in recovery pass2, but is leaked
in the error path.
Signed-off-by: Mark Tinguely<tinguely@xxxxxxx>
For this local leak & the fix,
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Since this gets called in a loop from xlog_recover_process_data(),
I'm wondering what happens to previously-allocated items, if we
return an error and never get to pass2?
(I could be off base, haven't really followed it through, but
it seems like they might leak).
Thanks,
-Eric
yeah you are correct, it looks like it gets leaked.
I will add it to the list.
Thanks.
--Mark.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
