On Tue, Sep 24, 2013 at 03:59:49PM -0500, Ben Myers wrote: > Hi Dave, > > On Wed, Sep 25, 2013 at 06:32:32AM +1000, Dave Chinner wrote: > > On Tue, Sep 24, 2013 at 10:33:24AM -0500, Ben Myers wrote: > > > ...but it looks like your fix is in xfs_bdstrat_cb, which wouldn't have been > > > involved in the stack you posted above. What am I missing? > > > > That the first hunk that changes xfs_bioerror_relse() fixes the bug > > that caused the assert failure through xfsbdstrat(). > > *blink* > > All I see in that first hunk are changes to comments. The second hunk seems to > contain the only functional change, highlighted above. You are right - it should not be reliably fixing the failure I'm seeing. I'm sure there was something else in this patch originally - I'll go back and check. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
