On Fri, Sep 06, 2013 at 09:27:01AM -0700, Christoph Hellwig wrote: > On Fri, Sep 06, 2013 at 09:54:12AM +1000, Dave Chinner wrote: > > Fair enough - I thought about that, but then realised we don't > > really have any "global" shared header files that fit this purpose. > > The only two really are xfs_fs.h - which is used for ioctl interface > > definitions - and xfs_types.h which is used for type definitions, > > not structure instances... > > > > So I'm not really sure where we'd put something like this without > > creating a new header file, and I don't really want to do that, > > either. > > We might need a new one, the headers still need major work anyway. > > If we start with > > xfs*_format.h - purely disk format > xfs_fs.h - ioctl and userspace ABI constants > > an > > xfs_shared.h > > and > xfs_kernel.h OK. I'm not a great fan of the "xfs_shared.h" name, I'll see if I can come up with something better.... > seem like logical additions to move most of the misc headers to instead > of all the silly ones for just a handful or two worth of prototypes. > > Note that a few non-format bits already sneaked into xfs_format.h > unfortunately, guess I need to watch more closely :) They did, for the same reason as I put these ones there. I'll move them to the "xfs_shared.h" once I create it.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
