On 8/22/13 9:05 AM, Mark Tinguely wrote: > On 08/21/13 17:40, Eric Sandeen wrote: >> Today, xfs_db's freesp -d command dumps out a bunch of numbers: >> >> # xfs_db -c "freesp -d" /dev/sdb1 >> 0 4 1 >> 0 5 1 >> 0 6 1 >> 0 7 1 >> 0 12 174772 >> ... >> >> which are not useful to the non-code-reading user. >> Add some headers: >> >> # xfs_db -c "freesp -d" /dev/sdb1 >> agno agbno len >> 0 4 1 >> 0 5 1 >> 0 6 1 >> 0 7 1 >> 0 12 174772 >> ... >> >> so there's at least some context. >> >> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx> >> --- >> >> p.s. - If folks want different strings, I'm game. > > > Seems like just yesterday, some reviewer was concerned about the verbosity of table headers... wait it was yesterday! Gawd, I love irony. > :) I'd submit that this case is a bit different - there is no context whatsoever to the table of numbers, and there will almost certainly be a very high data::header ratio. :) > Geoffrey comment len -> length is fine too. > > Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> Thanks for the review, -Eric > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
