On Tue, 2013-08-13 at 15:42 -0500, Rich Johnston wrote: > Hey Chandra, > > Nice addition to quotas. Just a couple of comments. > > On 08/06/2013 05:27 PM, Chandra Seetharaman wrote: > > . . . > > > > +/* > > + * fs_quota_statv is the used by Q_XGETQSTATV for a given file system. It > Remove extra word ^^^^ > > > + * provides a centralized way to get meta information about the quota > > + * subsystem. eg. space taken up for user, group, and project quotas, number > > + * of dquots currently incore. > > + * > > + * This version has proper versioning support with appropriate padding for > > + * future expansions, and ability to expand for future without creating any > > + * backwward compatibility issues. > backward is misspelled (extra w) > > > + * > > + * For Q_XGETQSTATV, user space caller need to specify fs_quota_statv.qs_version > > + * to the version of data they are interested in. Kernel will fill the data > > + * fields relevant to that version. > > + * > > + * If kernel does not support user space caller specified version, EINVAL will > > + * be returned. User space caller can then reduce the version number and retry > > + * the same command. > > + */ > This was a little difficult to follow, suggest rewording a little, > something like: > > Q_XGETQSTATV uses the passed in value of the requested version via > fs_quota_statv.qs_version to determine the return data layout of > fs_quota_statv. > > Will make all the suggested fixes. > It would be nice to get this information documented in the quotactl(2) > manpage similar to Q_XGETQSTAT. Once it is in the kernel will work with Jan Kara to add the relevant changes to user space. Thanks Chandra > > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
