On 08/13/2013 02:53 PM, Dave Chinner wrote: > On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote: >> From: Jie Liu <jeff.liu@xxxxxxxxxx> >> >> Replace roundup() with roundup_64() as we calculate min_logblks >> with 64-bit divisions. Hence, call roundup() will cause the >> following error while compiling a 32-bit kernel: >> >> fs/built-in.o: In function `xfs_log_calc_minimum_size': >> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3' >> >> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> >> Cc: Dave Chinner <dchinner@xxxxxxxxxx> >> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> > > You beat me to it, Jeff. I got an email from Fengguang's build farm, > too. :) Hi Dave, I'm on a longer vacations these days(until next week). I have asked my friend for help checking our mailing list to watch if there's any email for me before the leaving, so I got his phone call this morning for this bug. :) > > Your fix looks good. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Thanks for your quick review! -Jeff _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
