Re: [PATCH 24/49] xfs: kill xfs_vnodeops.[ch]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 26, 2013 at 02:18:41PM -0500, Mark Tinguely wrote:
> On 07/19/13 01:24, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >Now we have xfs_inode.c for holding kernel-only XFS inode
> >operations, move all the inode operations from xfs_vnodeops.c to
> >this new file as it holds another set of kernel-only inode
> >operations. The name of this file traces back to the days of Irix
> >and it's vnodes which we don't have anymore.
> >
> >Essentially this move consolidates the inode locking functions
> >and a bunch of XFS inode operations into the one file. Eventually
> >the high level functions will be merged into the VFS interface
> >functions in xfs_iops.c.
> >
> >This leaves only internal preallocation, EOF block manipulation and
> >hole punching functions in vnodeops.c. Move these to xfs_bmap_util.c
> >where we are already consolidating various in-kernel physical extent
> >manipulation and querying functions.
> >
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> 
> As already mentioned, xfs_inode_fork.c still has a unwanted include
> of now removed xfs_vnodeops.h.
> 
> A xfs_qm_dqrele(pdqp) does not exist in the copied code:

Yes, already fixed that here. It was causing test failures on
xfs/050.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux