On 7/26/13 11:12 AM, Ben Myers wrote: > Hey Josef, > > On Tue, Jul 09, 2013 at 03:07:27PM -0400, Josef Bacik wrote: >> I test some of the different mkfs options for btrfs, one set doesn't work >> properly with small file systems, so the fs won't mount. This is fine from a >> btrfs point of view, but tests that fail to mount the scratch fs will run >> anyway, so if it's a "fill the fs" sort of test this will wreak havoc. To fix >> this just error out of _scratch_mount fails. Thanks, >> >> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx> > > I noticed that this change causes dmapi tests to try to be run on systems that > don't have dmapi supported, and they fail. Have you seen this? > > Thanks, > Ben I haven't tested either way, but does: _mount -t $FSTYP `_scratch_mount_options $*` || _fail "Scratch mount failed" work any better? -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs