Re: [PATCH 19/48] xfs: buffer type overruns blf_flags field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 07, 2013 at 10:25:42AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The buffer type passed to log recvoery in the buffer log item
> overruns the blf_flags field. I had assumed that flags field was a
> 32 bit value, and it turns out it is a unisgned short. Therefore
> having 19 flags doesn't really work.
> 
> Convert the buffer type field to numeric value, and use the top 5
> bits of the flags field for it. We currently have 17 types of
> buffers, so using 5 bits gives us plenty of room for expansion in
> future....
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

This corresponds to commit 61fe135c1dde1.

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux