On Fri, Jul 19, 2013 at 07:34:57PM -0400, Eric Sandeen wrote: > On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@xxxxxxx> wrote: > > > Hey Eric, > > > > On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote: > >> The xfs_metadump manpage states that metadump works > >> on a frozen filesystem; it does not. In fact, there is > >> no way to detect a frozen filesystem, so we can't make it > >> work, either. > >> > >> So just remove this from the manpage; unmounted or RO > >> mounted is what is enforced by xfs_metadump. > >> > >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > > > I gave this a try and it *seemed* to work fine on a frozen filesystem. > > Can you provide a bit of detail about why xfs_metadump doesn't work on > > frozen filesystems? What am I missing? > > > > Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work? Gah. As we discussed on IRC, I was wrong. So, so wrong. Reviewed-by: Ben Myers <bpm@xxxxxxx> Applied. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
