On Wed, Jul 17, 2013 at 4:40 PM, Ben Myers <bpm@xxxxxxx> wrote: >> >> We're still talking at cross purposes then. >> >> How the hell do you handle mmap() and page faulting? > > __xfs_get_blocks serializes access to the block map with the i_lock on the > xfs_inode. This appears to be racy with respect to hole punching. Would it be possible to just make __xfs_get_blocks get the i_iolock (non-exclusively)? Or, alternatively, do it in the readpage() function? That was what I thought you did anyway. Exactly because of the whole page faulting issue. Linus _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs