On Mon, Jul 08, 2013 at 04:51:51PM -0500, Ben Myers wrote: > Hey Carlos & Eric, > > On Wed, Jun 12, 2013 at 04:23:20PM -0300, Carlos Maiolino wrote: > > I'm personally working on this bug with Eric, and the test properly trigger the > > bug on 100% of the test runs, but, it should also ensure that > > `irix_sgid_inherit` sysctl is set to 0, if not, the test will fail. > > > > follow is a suggestion for a better changelog: > > > > Tests if subdirectories created on the filesystem will properly inherit sgid bit > > when this is set on the parent directory, once the process has the properly > > permissions to create a subdirectory, this, should inherit parent's sgid bit if > > this is set and irix_sgid_inherit sysctl is disabled. > > I applied this and tested with Carlos's latest patch: > > generic/313 - output mismatch (see /root/xfstests/results/generic/313.out.bad) > --- tests/generic/313.out 2013-07-08 16:27:41.787710646 -0500 > +++ /root/xfstests/results/generic/313.out.bad 2013-07-08 16:47:46.052683735 -0500 > @@ -1,3 +1,3 @@ > QA output created by 313 > -drwxr-sr-x. TEST_DIR/313-dir/subdir > +drwxr-sr-x TEST_DIR/313-dir/subdir > drwxrwsr-x+ TEST_DIR/313-dir/subdir2 > ... > (Run 'diff -u tests/generic/313.out /root/xfstests/results/generic/313.out.bad' to see the entire diff) > > Looks like there could be a problem with ls? Have you seen that? > > Thanks, > Ben > Actually I don't think this is a problem, but the way newer `ls` versions are displaying the object permissions (the 'dot' at the end of the permissions, indicating there are no extra attributes). I'm going to take a look on what's going on, but I still believe it's just a matter of add the 'dot' to the xfstests correct output. I had this same problem when testing my patch and needed to fix it locally, but missed to warn you guys, my apologies -- Carlos _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
