On Wed, Jul 10, 2013 at 11:16:01PM -0500, Chandra Seetharaman wrote: > On Thu, 2013-07-11 at 11:45 +1000, Dave Chinner wrote: > > And to play Devil's advocate: it is way too late in the merge cycle > > to make these sorts of ABI changes to a patch and test/review them > > adequately. > > There is no ABI issues even in the earlier version, it was an API > breakage. Old binaries would have done the wrong thing - that's an ABI issue. I'm sorry I didn't realise this earlier. > And with Jan's suggestion even that API breakage is being > fixed. There is no change in API or ABI. We are just adding a new > interface. Yes, we are adding a new API to avoid ABI problems with re-interpreting the old API. But whether it's API or ABI, it doesn't matter - my point is that it's almost 2 weeks after the merge window was opened and adding new userspace APIs at the last moment before the merge window closes tends to be frowned upon.... > Old code and old binary will work as before. Yes, but we have no new code or binaries to test the new interface, do we? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
