On Thu, 2013-07-11 at 11:23 +1000, Dave Chinner wrote: > On Wed, Jul 10, 2013 at 04:46:38PM -0500, Chandra Seetharaman wrote: > > > > @@ -1160,13 +1160,13 @@ xfs_ioctl_setattr( > > > > */ > > > > xfs_qm_dqrele(olddquot); > > > > xfs_qm_dqrele(udqp); > > > > - xfs_qm_dqrele(gdqp); > > > > + xfs_qm_dqrele(pdqp); > > > > > > > > return code; > > > > > > > > error_return: > > > > xfs_qm_dqrele(udqp); > > > > - xfs_qm_dqrele(gdqp); > > > > + xfs_qm_dqrele(pdqp); > > > > xfs_trans_cancel(tp, 0); > > > > if (lock_flags) > > > > xfs_iunlock(ip, lock_flags); > > > > > > Here in xfs_ioctl_setattr, I'm not clear on why we're messing with the user > > > dquot at all. Could it be removed entirely? A change in project id doesn't > > > effect user quota, right? > > > > > > Maybe that's an idea for a separate patch. > > > > I will look into that after these get in :) > > The user dquot may have group and/or project dquot hints attached to > it. Therefore if we are changing project quota and user quotas are > enabled, then we may have to remove the hint from the user dquot > that points to the old project dquot.... Thanks for the explanation Dave. > > Cheers, > > Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
