On Tue, Jul 09, 2013 at 03:05:15PM +0400, Dmitry Monakhov wrote: > Currenly large_fs check compare $SCRATCH_DEV_EMPTY_SPACE and $fs_size > which is not correct because total empty size required is $SCRATCH_DEV_EMPTY_SPACE + 50Gb > This path fix space detection, so check becomes valid for all situations. I'm not sure what problem you're fixing from this description? It's takenme a few minutes to work out that: "If SCRATCH_DEV_EMPTY_SPACE + 50GB is larger than the filesystem size being tested, then the configuration being tested is invalid and should fail. Currently we only check that SCRATCH_DEV_EMPTY_SPACE is greater than the the filesystem size. Fix it to check the combined empty space fits in the filesystem being tested." Otherwise the change looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
