Hi Dave, Any comments ? Thanks Chandra On Mon, 2013-07-01 at 12:59 -0500, Chandra Seetharaman wrote: > On Mon, 2013-07-01 at 12:06 +1000, Dave Chinner wrote: > > On Thu, Jun 27, 2013 at 05:25:12PM -0500, Chandra Seetharaman wrote: > > > Start using pquotino and define a macro to check if the > > > superblock has pquotino. > > > > > > Keep backward compatibilty by alowing mount of older superblock > > > with no separate pquota inode. > > > > > > Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx> > > > > This is unchanged from the previous version, so all of my review > > comments from here: > > > > http://oss.sgi.com/pipermail/xfs/2013-June/027637.html > > > > are still unaddressed. > > See the other email I sent on this context. > > > > Also: > > > > > @@ -885,6 +905,18 @@ reread: > > > */ > > > xfs_sb_from_disk(&mp->m_sb, XFS_BUF_TO_SBP(bp)); > > > > > > + if (!xfs_sb_version_has_pquota(&mp->m_sb) && (XFS_IS_PQUOTA_ON(mp))) { > > > + /* > > > + * On disk superblock only has sb_gquotino, and incore > > > + * superblock has both sb_gquotino and sb_pquotino. > > > + * But, only one them is supported at any point of time. > > > + * So, if PQUOTA is set in disk superblock, copy over > > > + * sb_gquotino to sb_pquotino. > > > + */ > > > + mp->m_sb.sb_pquotino = mp->m_sb.sb_gquotino; > > > + mp->m_sb.sb_gquotino = NULLFSINO; > > > + } > > > + > > > xfs_sb_quota_from_disk(&mp->m_sb); > > > > This code should be inside xfs_sb_quota_from_disk().... > > will move. > > > > Cheers, > > > > Dave. > > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
