Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 19, 2013 at 09:13:14AM +1000, Dave Chinner wrote:
> On Tue, Jun 18, 2013 at 05:57:00PM -0500, Dave Kleikamp wrote:
> > The retval parameter to pthread_join() is a pointer to a pointer.
> > aio-stress is passing in a pointer to an int. This can result in a bus
> > error on sparc64 when the pointer is not aligned on a 64-bit boundary.
> > Since the return value is not used, it is simplest to pass a NULL
> > pointer instead.
> > 
> > This has been fixed in the LTP source:
> > https://github.com/linux-test-project/ltp/commit/981d33aad3b33c4625b88990fbf2fad5470d47e0
> > 
> > Signed-off-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>
> 
> Looks good. Thanks, Shaggy.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Applied.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux