Hi Dave, I like this version a lot better from a quick glance. A few more comments: - do we really want all that many separate _format.h headers? I'd be really tempted to say we have just a single xfs_format.h header, which should declare everything. It's still not all that large, and it would be a really good start to ease our include mess. - xfs_extent_ops.c still has that odd _ops.c name I hate because it tends to imply it's an implementation of some ops vector. How about xfs_alloc_util.c to go with the other _util name you added? - any chance to reorder the inode.c split so that stuff doesn't get move around multiple times? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
