On Mon, Jun 17, 2013 at 03:35:57PM -0500, Mark Tinguely wrote: > a > Content-Disposition: inline; filename=v4-xfs-fix-assert-in-xfs_ifree.patch > > Adding an extended attribute to a symbolic link can force that > link to an remote extent. xfs_inactive() incorrectly assumes > that any symbolic link small enough to be in the inode core > is incore, resulting in the remote extent to not be removed. > xfs_ifree() will assert on presence of this leaked remote extent. > > Signed-off-by: Mark Tinguely <tinguely@xxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> One minor, minor thing: > + if (pathlen < 0 || pathlen > MAXPATHLEN) { > + xfs_alert(mp, "%s: inode (%llx) bad symlink length (%d)", (0x%llx) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs