On Tue, Jun 18, 2013 at 03:53:51PM +1000, Dave Chinner wrote: > > I'd rather opencode updating the mode here, it's really just a tiny bit > > of boilerplate code. > > Needs a transaction, though. Right now, there's no transaction code > at all in xfs_acl.c and I'd kind of like to keep it that way as it's > just a translation layer.... True. Maybe as a quick hack just extend the meaning of XFS_ATTR_NOACL to also not do the checks? It's already the magic flag to mean that we are called from the ACL code. Alternatively move all of xfs_set_mode, or at least everything around the "if (mode != inode->i_mode) " to xfs_iops.c. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
