This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree". The branch, master has been updated 1ebdf36 xfs: Remove struct xfs_chash from xfs_mount 34d7f60 xfs: Don't keep silent if sunit/swidth can not be changed via mount 897366f xfs: Remove redundant error variable from xfs_growfs_data_private() b2410e9 xfs: Convert use of typedef ctl_table to struct ctl_table from 9222a9cf86c0d64ffbedf567412b55da18763aa3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1ebdf3611c8968e7202c47c2dcb2d36986c44cb0 Author: Jeff Liu <jeff.liu@xxxxxxxxxx> Date: Thu May 2 19:23:20 2013 +0800 xfs: Remove struct xfs_chash from xfs_mount Remove struct xfs_chash from struct xfs_mount as there is no user of it nowadays. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> Signed-off-by: Ben Myers <bpm@xxxxxxx> commit 34d7f603b93be0ac38c2464219f5a2795d76c8ee Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu May 2 19:27:53 2013 +0800 xfs: Don't keep silent if sunit/swidth can not be changed via mount As per the mount man page, sunit and swidth can be changed via mount options. For XFS, on the face of it, those options seems works if the specified alignments is properly, e.g. # mount -o sunit=4096,swidth=8192 /dev/sdb1 /mnt # mount | grep sdb1 /dev/sdb1 on /mnt type xfs (rw,sunit=4096,swidth=8192) However, neither sunit nor swidth is shown from the xfs_info output. # xfs_info /mnt meta-data=/dev/sdb1 isize=256 agcount=4, agsize=262144 blks = sectsz=512 attr=2 data = bsize=4096 blocks=1048576, imaxpct=25 = sunit=0 swidth=0 blks ^^^^^^^^^^^^^^^^^^^^^^^^^^ naming =version 2 bsize=4096 ascii-ci=0 log =internal bsize=4096 blocks=2560, version=2 = sectsz=512 sunit=0 blks, lazy-count=1 realtime =none extsz=4096 blocks=0, rtextents=0 The reason is that the alignment can only be changed if the relevant super block is already configured with alignments, otherwise, the given value is silently ignored. With this fix, the attempt to mount a storage without strip alignment setup on a super block will get an error with a warning in syslog to indicate the true cause, e.g. # mount -o sunit=4096,swidth=8192 /dev/sdb1 /mnt mount: wrong fs type, bad option, bad superblock on /dev/sdb1, missing codepage or helper program, or other error In some cases useful info is found in syslog - try dmesg | tail or so ....... XFS (sdb1): cannot change alignment: superblock does not support data alignment Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Cc: Mark Tinguely <tinguely@xxxxxxx> Cc: Dave Chinner <dchinner@xxxxxxxxxx> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> Signed-off-by: Ben Myers <bpm@xxxxxxx> commit 897366f0e4bdc320ade81c3c4035977c99de9aad Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Tue May 14 22:50:21 2013 +0800 xfs: Remove redundant error variable from xfs_growfs_data_private() Commit eab4e633 "xfs: uncached buffer reads need to return an error". Remove redundant error variable, using the function level error variable to store bp->b_error instead. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Ben Myers <bpm@xxxxxxx> Signed-off-by: Ben Myers <bpm@xxxxxxx> commit b2410e92b70507e054deb6cdb605ee1d61fc7c95 Author: Joe Perches <joe@xxxxxxxxxxx> Date: Thu Jun 13 19:37:50 2013 -0700 xfs: Convert use of typedef ctl_table to struct ctl_table This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Acked-by: Dave Chinner <dchinner@xxxxxxxxxx> Reviewed-by: Ben Myers <bpm@xxxxxxx> Signed-off-by: Ben Myers <bpm@xxxxxxx> ----------------------------------------------------------------------- Summary of changes: fs/xfs/xfs_fsops.c | 2 +- fs/xfs/xfs_mount.c | 4 ++++ fs/xfs/xfs_mount.h | 2 -- fs/xfs/xfs_sysctl.c | 26 +++++++++++++------------- 4 files changed, 18 insertions(+), 16 deletions(-) hooks/post-receive -- XFS development tree _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs