On 06/06/13 20:06, Dave Chinner wrote:
On Thu, Jun 06, 2013 at 11:10:33AM -0500, Mark Tinguely wrote:Adding an extended attribute to a symbolic link can force that link to an remote extent. xfs_inactive() incorrectly assumes that any symbolic link small enough to be in the inode core is incore, the remote extent is not cleaned and xfs_ifree() asserts on presence the remote extent. Signed-off-by: Mark Tinguely<tinguely@xxxxxxx> --- fs/xfs/xfs_vnodeops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/fs/xfs/xfs_vnodeops.c =================================================================== --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c @@ -325,7 +325,7 @@ xfs_inactive( /* * Zero length symlinks _can_ exist. */ - if (ip->i_d.di_size> XFS_IFORK_DSIZE(ip)) { + if (ip->i_d.di_nextents) { error = xfs_inactive_symlink_rmt(ip,&tp); if (error) goto out_cancel;This should match the check done in xfs_readlink. i.e. it should check against the fork format being in local or extent form, not check against the inode size. Also, I think that this symlink specific code should be factored out of xfs_inactive() and moved to fs/xfs/xfs_symlink.c as xfs_symlink_truncate() so that all the intricacies of the symlink truncation are in the one place. This would make xfs_symlink_truncate() look very similar to xfs_readlink()...
Sounds good. --Mark. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
