On Thu, May 30, 2013 at 08:42:29AM -0500, Eric Sandeen wrote: > On 5/30/13 3:07 AM, alexander.tsvetkov@xxxxxxxxxx wrote: > > I think the following code of "check" script incorrectly builds this exclude list: > > > > "-X) xfile=$2; shift ; > > for d in $SRC_GROUPS $FSTYP; do > > [ -f $SRC_DIR/$d/$xfile ] || continue > > for f in `cat $SRC_DIR/$d/$xfile`; do > > echo $d/$f >> $tmp.xlist > > Well, it is perhaps unexpected, but: > > -X file exclude individual tests > > I think it's designed to actually exclude tests contained in that > file, not test numbers. It's not very obvious. :( Right, it's a file full of test numbers to expunged. Two things can be done here: 1. improve the description 2. change the `cat $file` to `egrep ^$SUPPORTED_TESTS $file` so that it requires files in the same format as group files. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
