On Fri, May 17, 2013 at 09:03:14AM +1000, Dave Chinner wrote: > As it is, the static checker missed the: > > rounding = max_t(uint, ....); > > The line before the above usage. I posted a patch to fix this this > 2 weeks ago here: > > http://oss.sgi.com/pipermail/xfs/2013-May/025986.html > Ah. Grand. There is still a problem with the max_t(). The shift operation will wrap before we do the cast. It should be: - rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE); + rounding = max_t(xfs_off_t, 1ULL << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE); regards, dan carpenter _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
