On Mon, May 13, 2013 at 10:44:39AM +1000, Dave Chinner wrote:
> On Sun, May 12, 2013 at 07:34:24PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> >
> > After applied this commit (864688d3), xfstests #255 will not test a
> > file system that cannot support fallocate(2), such as a indirect-based
> > file in ext4. So we need to add a new generic test case to test it.
> >
> > The difference between #255 and this test case is only to use pwrite to
> > allocate blocks. Other filesystems should survive in this test case.
> > In the mean time, a new argument '-u' is added into _test_generic_punch
> > not to run unwritten tests.
> >
> > Meanwhile this commit fixes a minor problem in #255 that testfile should
> > use $seq.$$ as testfile.
> >
> > Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> > Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
> > Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> > Cc: Rich Johnston <rjohnston@xxxxxxx>
>
> This will need to be rebased on top of Eric's patch that removes the
> need to pass -F to xfs_io for non-xfs filesystems....
Hi Dave,
Thanks for review. I guess that you metioned this patch, right?
[PATCH] xfstests: automatically add -F to xfs_io on non-xfs
But I couldn't find it in xfstests tree. Has it been applied into the
tree? Or maybe I use a wrong tree to generate my patch. I clone the
tree from here:
git://oss.sgi.com/xfs/cmds/xfstests
Is that right? Or maybe I need to apply Eric's patch manually and
rebase my patch?
>
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -114,3 +114,4 @@
> > 309 auto quick
> > 310 auto
> > 311 auto metadata log
> > +314 auto quick prealloc
>
> Why would you add it to the prealloc group? The whole point of the
> test is that it doesn't use prealloc, right?
Good catch! Fix it soon.
Thanks,
- Zheng
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
