On Tue, May 07, 2013 at 09:35:06PM -0500, Eric Sandeen wrote: > The -F flag to xfs_io originally enabled it to operate on non-xfs > filesystems. This restriction was removed upstream in favor of > gracefully failing on the handful of operations that actually > required xfs, and the option was deprecated. > > However, xfstests is still used on distros with older xfsprogs, and > so "xfs_io -F" was necessary throughout xfstests. > > Simplify this by appending -F to XFS_IO_PROG when it's needed - > i.e. if we're using old xfsprogs on a non-xfs filesystem. > > This will eliminate errors when new tests leave out the -F, and > if and when -F is finally removed, there will be one central > location in xfstests to update. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > V2: test for necessity of -F in all cases, and convert > a bunch more direct callers of xfs_io to $XFS_IO_PROG Yup, that fixes the one concern I had with the first patch. Loks good. Acked-by: Dave Chinner <dchinner@xxxxxxxxxx> Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
