Hello Dave Chinner,
The patch d75afeb3d302: "xfs: add buffer types to directory and
attribute buffers" from Apr 3, 2013, leads to the following Smatch warning:
"fs/xfs/xfs_log_recover.c:2042 xlog_recovery_validate_buf_type()
warn: always true condition '(magicda != 1480675917) => (0-u16max != 1480675917)'"
fs/xfs/xfs_log_recover.c
2039 case XFS_BLFT_ATTR_RMT_BUF:
2040 if (!xfs_sb_version_hascrc(&mp->m_sb))
2041 break;
2042 if (magicda != XFS_ATTR3_RMT_MAGIC) {
^^^^^^^
This is an unsigned short so it can never be equal to 0x5841524d. Was
"magic32" intended here?
2043 xfs_warn(mp, "Bad attr remote magic!");
2044 ASSERT(0);
2045 break;
2046 }
2047 bp->b_ops = &xfs_attr3_rmt_buf_ops;
2048 break;
regards,
dan carpenter
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
