On 05/02/13 06:27, Jeff Liu wrote:
From: Jie Liu<jeff.liu@xxxxxxxxxx>
XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if
mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)"
branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so
we always be emitting a warning and returning an error.
Hence, we can remove it and get rid of a couple of redundant
check up against it at xfs_upate_alignment().
Thanks Dave Chinner for the suggestions of simplify the code
in xfs_parseargs().
Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
"alignment check failed: sunit/swidth vs. blocksize(%d)",
^^^^
"alignment check failed: sunit/swidth vs. agsize(%d)",
^^^^
"alignment check failed: sunit(%d) less than bsize(%d)",
^^^^ ^^^^
I know you copied these statements verbatim, but I wonder why all
these statements do not have a space between the type and value?
Looks good.
Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
