[PATCH 3/3] xfstests: Do not fail on empty exclude groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Boris Ranto <ranto.boris@xxxxxxxxx>

Currently, xfstests will fail as soon as it detects an empty exclude
group. However, this may cause problems in automated testing. For
example, if one wishes to exclude otherwise valid group dmapi for file
system like tmpfs or nfs, the ./check script will hit the error about
empty group and fail. This simple patch changes the error to warning,
prints the warning to stderr and simply continue without excluding
anything as there are no tests to be excluded.

Signed-off-by: Boris Ranto <ranto.boris@xxxxxxxxx>
---
 check |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/check b/check
index 4af2dbd..b888030 100755
--- a/check
+++ b/check
@@ -194,12 +194,13 @@ while [ $# -gt 0 ]; do
 		[ ! -s $tmp.list ] && get_all_tests
 
 		group_list=$(get_group_list $xgroup)
+		# Trim the test list only if there is something to trim it with
 		if [ -z "$group_list" ]; then
-		    echo "Group \"$xgroup\" is empty or not defined?"
-		    exit 1
+		    echo "Warning: Group \"$xgroup\" seems empty." 1>&2
+		else
+		    trim_test_list $group_list
 		fi
 
-		trim_test_list $group_list
 		;;
 
 	-X)	xfile=$2; shift ;
-- 
1.7.1

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux