On 04/22/2013 11:18 AM, Chandra Seetharaman wrote:
Is there any specific reason why quota_proj_type() is not changed ?
Yes project quota's were being punished. ;) Good catch Chandra, I will submit a V3. 3 times seems to be the charm on patches. :D Thanks --Rich
On Mon, 2013-04-22 at 08:31 -0500, rjohnston@xxxxxxx wrote:
Index: xfsprogs/quota/quota.c =================================================================== --- xfsprogs.orig/quota/quota.c 2013-03-22 14:22:09.000000000 -0500 +++ xfsprogs/quota/quota.c 2013-04-22 07:20:52.000000000 -0500 @@ -224,7 +224,7 @@ uid_t id; if (name) { - if (isdigit(name[0])) { + if (isdigits_only(name)) { id = atoi(name); name = getusername(id, flags & NO_LOOKUP_FLAG); } else if ((u = getpwnam(name))) { @@ -273,7 +273,7 @@ int i, ngroups, dofree = 0; if (name) { - if (isdigit(name[0])) { + if (isdigits_only(name)) { gid = atoi(name); name = getgroupname(gid, flags & NO_LOOKUP_FLAG); } else { Index: xfsprogs/quota/quota.h =================================================================== --- xfsprogs.orig/quota/quota.h 2013-03-22 14:22:09.000000000 -0500 +++ xfsprogs/quota/quota.h 2013-04-22 08:12:26.000000000 -0500 @@ -19,6 +19,7 @@ #include <xfs/xqm.h> #include <xfs/path.h> #include <xfs/project.h> +#include <stdbool.h> /* * Different forms of XFS quota @@ -80,4 +81,5 @@ extern char *uid_to_name(__uint32_t __uid); extern char *gid_to_name(__uint32_t __gid); extern char *prid_to_name(__uint32_t __prid); +extern bool isdigits_only(const char *); _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
