Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 12, 2013 at 01:41:22PM -0500, Rich Johnston wrote:
> On 04/12/2013 11:42 AM, Wang Sheng-Hui wrote:
> >
> >Hi Dave,
> >
> >I introduces Makefile under tests/, which would return to TESTS_SUBDIRS
> >with the
> >$(dir function. By running find in $(shell, TEST_SUBDIRS will only get
> >the dir names,
> >and no Makefile.
> >
> >Regards,
> >Sheng-Hui
> 
> Thanks addressing comments and for v2 of this patch.
> 
> I still had issues with Makefile which I corrected at commit time.
> 
> Thanks again for the patch, it has been committed,

Rich, it's great that you are picking this stuff up quickly, but as
I asked recently, please don't commit patches while there is still
an active review conversation going on....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux