On Fri, Apr 12, 2013 at 02:12:35PM +0800, Wang Sheng-Hui wrote: > In group files, non comment line starts with a 3-digits, then followed by > space and other characters, but no group names. I don't follow. A group file line looks like: 003 db auto quick Which defines the test name, followed by the group names the test belongs to. > The old regex in get_group_list uses the group name as part of the regex, > and fails './check -g xfs' run: > Group "xfs" is empty or not defined? Well, yes, "xfs" is not a defined group name: $ grep xfs tests/*/group $ If I define a "xfs" group by assigning tests to it, check runs just fine. $ grep xfs tests/*/group tests/xfs/group:003 db auto quick xfs $ sudo ./check -g xfs FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 test-2 3.9.0-rc4-dgc+ MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb MOUNT_OPTIONS -- /dev/vdb /mnt/scratch xfs/003 1s Ran: xfs/003 Passed all 1 tests $ So what check is doing looks perfectly OK to me and doesn't need changing. > The patch removes the pattern for group name, and thus we can trigger tests > like "./check -g xfs" as normal. If you want to run all the tests in a specific subdirectory regardless of groups, then you can do it like: $ sudo ./check xfs/[0-9][0-9][0-9] FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 test-2 3.9.0-rc4-dgc+ MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb MOUNT_OPTIONS -- /dev/vdb /mnt/scratch xfs/003 0s xfs/004 0s xfs/008 1s ..... There's definitely better ways to do this, but conflating source tree layout with runtime test group definitions is not it. ;) Perhaps something like "check xfs" will just run all tests in the xfs test dir, similar for ext4, shared, etc? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
