Re: [PATCH] xfstests: fix common rc file path in new

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 28, 2013 at 09:51:23PM +0800, Eryu Guan wrote:
> After the re-factor common.rc has been renamed to common/rc, fix the
> path in script new, otherwise ./new reports
> 
> ./new: line 26: ./common.rc: No such file or directory
> Building include
> Building lib
> Building ltp
> Building src
> Building m4
> ./new: line 70: BEGIN{printf "%03d\n",+1}: command not found
> Next test is
> Error: test  already exists!
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
> After applying this patch, ./new generates new test starting from 001,
> so we have to maintain the seq number manually? Do we need an updated
> version of new? eg. takes an argument to specify the test type like
> 
> 	./new generic
> 
> and generates new test based on existing seq number in generic dir.

We could, but this all has to change when we allow non-numeric test
names.  i.e. the 'new' script is just creating a test template and
you can simply copy it to where ever you need with the appropriate
name. So just fixing the includes are appropriate right now, I
think...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux