On 3/20/13 12:45 AM, Zheng Liu wrote: >>> +f6aeca13ec49e5b266cd1c913cd726e3 >>> > > + 12. unwritten -> data -> unwritten >> > >> > It's a little odd that the output contains "unwritten" when this test >> > is explicitly for testing *without* unwritten extents. Should this be >> > cleaned up a little in common.punch, maybe? > I will try to define a new function called _test_indirect_punch() to > test punching hole without unwritten extent. It's just the helper which prints "unwritten" regardless of what is passed as "$alloc_cmd" to _test_generic_punch, right... so there's nothing wrong with the test, really - it's just odd output. I'm not sure it's worth a big copy & paste just to change the output text, but if you can think of something simple to clean it up, it might be worth it. -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
