Re: [PATCH 02/21] xfs: increase hexdump output in xfs_corruption_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 12, 2013 at 11:30:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Currently xfs_corruption_error() dumps the first 16 bytes of the
> buffer that is passed to it when a corruption occurs. This is not
> large enough to see the entire state of the header of the block that
> was determined to be corrupt.  increase the output to 64 bytes to
> capture the majority of all headers in all types of metadata blocks.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_error.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 07bf3b9..35d3f5b 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -178,7 +178,7 @@ xfs_corruption_error(
>  	inst_t			*ra)
>  {
>  	if (level <= xfs_error_level)
> -		xfs_hex_dump(p, 16);
> +		xfs_hex_dump(p, 64);

Are you sure we don't have any structures which are shorter than that?  I guess
we'll have to take a look.

-Ben

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux