On 3/13/13 10:32 AM, Stefan Behrens wrote: > On Wed, 13 Mar 2013 09:57:03 -0500, Eric Sandeen wrote: > [...] >> +echo "== Show device stats by mountpoint" >> +$BTRFS_UTIL_PROG device stats $SCRATCH_MNT | _filter_btrfs_device_stats > > Is the number of devices in SCRATCH_DEV_POOL fixed to 3? Otherwise you > should pipe the device-stats-by-mountpoint through "head -10" to avoid > failures if the number of devices is != 3. Oh, you are right. I had meant to filter device stats through "uniq" after replacing all devices & numbers. I'll add that, then I think it should be ok. thanks for catching that. > Possible additional checks (but I am not sure that we really need this > additional level of detail in this check) would be: > 1. The number of lines is 5 * number of devices. > 2. The 5-line block that is printed for each device always looks the > same (after applying _filter_btrfs_device_stats). hm, perhaps - I wonder if that might be fragile? I guess if *any* output changes, the test will break . . . Thanks for the review! -Eric >> +echo "== Show device stats by first/scratch dev" >> +$BTRFS_UTIL_PROG device stats $SCRATCH_DEV | _filter_btrfs_device_stats >> +echo "== Show device stats by second dev" >> +$BTRFS_UTIL_PROG device stats $FIRST_POOL_DEV | sed -e "s,$FIRST_POOL_DEV,FIRST_POOL_DEV,g" >> +echo "== Show device stats by last dev" >> +$BTRFS_UTIL_PROG device stats $LAST_POOL_DEV | sed -e "s,$LAST_POOL_DEV,LAST_POOL_DEV,g" >> + >> +# success, all done >> +status=0 >> +exit >> diff --git a/313.out b/313.out >> new file mode 100644 >> index 0000000..1aa59a1 >> --- /dev/null >> +++ b/313.out >> @@ -0,0 +1,51 @@ >> +== QA output created by 313 >> +== Set filesystem label to TestLabel.313 >> +== Get filesystem label >> +TestLabel.313 >> +== Mount. >> +== Show filesystem by label >> +Label: 'TestLabel.313' uuid: <UUID> >> + Total devices <EXACTNUM> FS bytes used <SIZE> >> + devid <DEVID> size <SIZE> used <SIZE> path SCRATCH_DEV >> + >> +== Show filesystem by UUID >> +Label: 'TestLabel.313' uuid: <EXACTUUID> >> + Total devices <EXACTNUM> FS bytes used <SIZE> >> + devid <DEVID> size <SIZE> used <SIZE> path SCRATCH_DEV >> + >> +== Sync filesystem >> +FSSync 'SCRATCH_MNT' >> +== Show device stats by mountpoint >> +[SCRATCH_DEV].write_io_errs <NUM> >> +[SCRATCH_DEV].read_io_errs <NUM> >> +[SCRATCH_DEV].flush_io_errs <NUM> >> +[SCRATCH_DEV].corruption_errs <NUM> >> +[SCRATCH_DEV].generation_errs <NUM> >> +[SCRATCH_DEV].write_io_errs <NUM> >> +[SCRATCH_DEV].read_io_errs <NUM> >> +[SCRATCH_DEV].flush_io_errs <NUM> >> +[SCRATCH_DEV].corruption_errs <NUM> >> +[SCRATCH_DEV].generation_errs <NUM> >> +[SCRATCH_DEV].write_io_errs <NUM> >> +[SCRATCH_DEV].read_io_errs <NUM> >> +[SCRATCH_DEV].flush_io_errs <NUM> >> +[SCRATCH_DEV].corruption_errs <NUM> >> +[SCRATCH_DEV].generation_errs <NUM> > > 3 devices in this case. Yep, oops. >> +== Show device stats by first/scratch dev >> +[SCRATCH_DEV].write_io_errs <NUM> >> +[SCRATCH_DEV].read_io_errs <NUM> >> +[SCRATCH_DEV].flush_io_errs <NUM> >> +[SCRATCH_DEV].corruption_errs <NUM> >> +[SCRATCH_DEV].generation_errs <NUM> >> +== Show device stats by second dev >> +[FIRST_POOL_DEV].write_io_errs 0 >> +[FIRST_POOL_DEV].read_io_errs 0 >> +[FIRST_POOL_DEV].flush_io_errs 0 >> +[FIRST_POOL_DEV].corruption_errs 0 >> +[FIRST_POOL_DEV].generation_errs 0 >> +== Show device stats by last dev >> +[LAST_POOL_DEV].write_io_errs 0 >> +[LAST_POOL_DEV].read_io_errs 0 >> +[LAST_POOL_DEV].flush_io_errs 0 >> +[LAST_POOL_DEV].corruption_errs 0 >> +[LAST_POOL_DEV].generation_errs 0 > [...] > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
