On 3/3/13 4:53 PM, Richard Weinberger wrote: >> Anyway, what if you did something more along the lines of [pseudocode] >> >> ocfs2) >> if mounted.ocfs2 -f $TEST-DEV | frob_as_necessary[1] >> ; >> else >> fsck.ocfs2 $TEST-DEV >> fi >> ;; >> >> so that *if* it's mounted on some other node, the fsck won't run. >> That has downsides as Dave mentioned, but for the case where the >> xfstests node is the only one with it in use, it'll still do the >> beneficial consistency check. >> >> Just tweaking the fsck action bsed on *if* it's mounted (or, >> maybe, if the node is in a cluster?) might be a more generic solution >> that is widely applicable to all ocfs2 test environments. > > Good point. mounted.ocfs2 really makes sense. I'll implement this on my > test suite and submit a new patch. Sounds good to me. It'd be most preferable to do a cluster-wide unmount and fsck, but if that's unfeasible, then skipping the fsck (with a warning) is still preferable to simply disabling it outright for everyone. Thanks, -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
