On 2/27/13 5:04 PM, Dave Chinner wrote:
> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
>> -x option of filefrag, and will fail with
>> 'FIBMAP: Invalid argument'
>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>> 'FIEMAP failed with unsupported flags 2'
>> Remove the '-x' option.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
>
> I can see that this changes what gets dumped into the $seq.full
> file, but it seems to me that also changes the extent list returned
> to the checking functions. So either the test previously worked and
> now it fails with this change, or the test never worked and now it
> does, or perhaps something else?
Agreed - I wondered as well.
> IOWs, I can't tell why you want to change this from the patch
> description, hence I don't know if the original behaviour was
> intentional or not. Can you say describe what the overall effect of
> the change is in the commit description?
It looks like -x is only recently rejected:
commit 05dadc09f52ad5a631da1aa8767c5b80e121f0c4
Author: Tsutomu Itoh <t-itoh@xxxxxxxxxxxxxx>
Date: Thu Nov 29 05:08:26 2012 +0000
Btrfs: add fiemap's flag check
+#define BTRFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC)
+ ret = fiemap_check_flags(fieinfo, BTRFS_FIEMAP_FLAGS);
-Eric
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
