If the SGI folks are still resistant to removing the bitrotted performance tests, I have a much simpler patch which we've been using inside Google for a while now which allows for alphanumeric tests "numbers". This allows us to use tests such as "g001", "g002", etc., without having to worry about test number collisions fom upstream. That would also be useful for ext4 since we could keep a fork of xfstests with e001, e002, e003, etc., while we wait for the tests to be reviewed for inclusing in the SGI tree. I hadn't bothered submitting it since it was clear Dave's changes was better, but the advantage of the hack we've been using inside Google is that it's a much less intrusive patch. The reason why I'm interested in having e001, e002, etc., patches is that at the moment we've got a number of people using private xfstests repositories and reporting regressions based on them. They are using numbers such as "301", which is very confusing since they aren't upstream and there's a chance the test may get renumbered by the time it does go upstream. The advantage of using a named-based system, or using patch numbers such as e001, g001, etc., is that it makes it a lot easier to keep track of tests that haven't made it upstream to the xfstests git repository. Cheers, - Ted P.S. I'm happy to review Dmitry's patches if it will help, but I wasn't sure whether you were looking for someone more experienced with the xfstests code base to review them. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
