Re: xfsprogs: fix warning in libxcmd/input.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/01/13 15:36, Ben Myers wrote:
Fix an error when building with -Werror=format-security.

input.c: In function 'fetchline':
input.c:91:2: error: format not a string literal and no format arguments [-Werror=format-security]

Signed-off-by: Ben Myers<bpm@xxxxxxx>
Reported by: Arkadiusz Miśkiewicz<arekm@xxxxxxxx>
Index: xfsprogs/libxcmd/input.c
===================================================================
--- xfsprogs.orig/libxcmd/input.c	2013-02-01 15:29:47.069894522 -0600
+++ xfsprogs/libxcmd/input.c	2013-02-01 15:30:00.845895188 -0600
@@ -88,7 +88,7 @@

  	if (!line)
  		return NULL;
-	printf(get_prompt());
+	printf("%s", get_prompt());
  	fflush(stdout);
  	if (!fgets(line, MAXREADLINESZ, stdin)) {
  		free(line);

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux